Skip to content
This repository has been archived by the owner on Aug 27, 2023. It is now read-only.

Arc support #285

Open
wants to merge 2 commits into
base: experimental
Choose a base branch
from
Open

Arc support #285

wants to merge 2 commits into from

Conversation

Capo01
Copy link

@Capo01 Capo01 commented Nov 6, 2017

I have been testing the arc supported branch with a pen potter on an Arduino mega and it appears to work just fine.

@Traumflug
Copy link
Owner

Thanks a lot for trying!

As Github found out already:

This branch has conflicts that must be resolved

Next to resolving conflicts, this branch needs more work:

  • Wrap the new code in a #define like SUPPORT_ARC. Typically printers need no arc support, G-code generators resolve this in a more general way already.
  • Add this #define to the configuration files.
  • Bonus points for adding it to Configtool, too.
  • Wrap arc debug code in #ifdef DEBUG.
  • Remove this RESUME_PIN stuff.
  • Remove this E endstop stuff (extruders have no endstop).
  • Remove all the commented code.
  • Fix intentation (replace tabs by spaces, indentation is 2 spaces).

In short: this code needs some love.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants